Skip to content

Remove ZetaSQL#35662

Merged
Abacn merged 2 commits intoapache:masterfrom
Abacn:remove-zetasql
Jul 28, 2025
Merged

Remove ZetaSQL#35662
Abacn merged 2 commits intoapache:masterfrom
Abacn:remove-zetasql

Conversation

@Abacn
Copy link
Contributor

@Abacn Abacn commented Jul 23, 2025

Fix #34423

Needed for #26403. An attempt of upgrade vendored Calcite (#35588) shows multiple zetasql tests breaking: https://github.com/apache/beam/runs/46517620722

Per #34423

Continued support for ZetaSQL component involving significant burdens,
like conflict with other Beam dependencies, supported Java versions, etc, or

We need to remove ZetaSQL components as we're not going to fix these breakages given the deprecation status. Merge after 2.67 release cut according to the plan.

Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 23, 2025

Assigning reviewers:

R: @shunping for label python.
R: @robertwb for label java.
R: @jrmccluskey for label go.
R: @damccorm for label build.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

damccorm
damccorm approved these changes Jul 24, 2025
View reviewed changes
Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - this LGTM. Before merging, please send a message to dev@ and user@ calling out the change.

@codecov
Copy link

codecov bot commented Jul 24, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.54%. Comparing base (da885fc) to head (93c0f1b).
⚠️ Report is 29 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master   #35662   +/-   ##
=========================================
  Coverage     56.54%   56.54%           
  Complexity     3381     3381           
=========================================
  Files          1204     1203    -1     
  Lines        183949   183895   -54     
  Branches       3490     3490           
=========================================
- Hits         104010   103988   -22     
+ Misses        76613    76582   -31     
+ Partials       3326     3325    -1
Flag Coverage Δ
go 28.24% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Abacn
Copy link
Contributor Author

Abacn commented Jul 24, 2025

Thank you @damccorm, sent https://lists.apache.org/thread/j5n9qz628wjmr0f3p28db6z1zbjdznbk and https://lists.apache.org/thread/qv5qtss8slrzz7zg25y60ptojwfdbwg7

@Abacn Abacn merged commit 06b622c into apache:master Jul 28, 2025
148 of 149 checks passed
@Abacn Abacn deleted the remove-zetasql branch July 28, 2025 19:32
@Abacn Abacn mentioned this pull request Aug 11, 2025
Open
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@damccorm damccorm damccorm approved these changes

Assignees

No one assigned

Labels

build examples extensions go java Next Action: Reviewers python sql yaml

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Task]: Deprecate ZetaSQL

2 participants

@Abacn @damccorm